Improvement: Add Conjure ErrorCode enum type
#171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Successfully generated changelog entry!What happened?Your changelog entries have been stored in the database as part of our migration to ChangelogV3. Entry generated via PR titleTo modify this entry, edit PR title using proper format. 📋Changelog Preview💡 Improvements
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
The
ErrorCodeisn't captured as part of the library. It would've been handy for my work resolving palantir/conjure-python#910 where theErrorCodewill be imported and used as part of the generated Conjure Error.After this PR
Adding the enum type and make
ConjureHTTPErroruse that. Since it's a stringish enum, it should be generally free from back compat issues.==COMMIT_MSG==
Add Conjure
ErrorCodeenum type==COMMIT_MSG==
Possible downsides?