Skip to content

Conversation

@iamdanfox
Copy link
Contributor

@iamdanfox iamdanfox requested a review from a team as a code owner June 27, 2018 16:54
@uschi2000
Copy link
Contributor

What does this mean for us?

- New: Honor the Retry-After response header. HTTP 503 (Unavailable) responses are retried automatically if this header is present and its delay is 0 seconds. HTTP 408 (Client Timeout) responses are retried automatically if the header is absent or its delay is 0 seconds.

@iamdanfox
Copy link
Contributor Author

iamdanfox commented Jun 27, 2018

Not sure yet - @dansanduleac is most interested in upgrading to okhttp 3.10.0 because it supports, conscrypt so just wanted to see whether http-remoting was going to work!!

EDIT apparently the internal CRP product is using 3.10.0 and it seems to be working for them (??)

@carterkozak
Copy link
Contributor

Note that 3.10.0 removed support for hostname verification via CN, and only validates SAN values.
This is ideal and matches modern versions of chrome, though if we're worried about breaking things we can supply our own HostnameVerifier instance to okhttp.

@jkozlowski jkozlowski mentioned this pull request Aug 30, 2018
4 tasks
@iamdanfox
Copy link
Contributor Author

Closing in favour of #794

@iamdanfox iamdanfox closed this Aug 30, 2018
@iamdanfox iamdanfox deleted the iamdanfox-patch-1 branch November 5, 2018 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants