Add UserAgents.of(UserAgent, Iterable<Agent>) #902
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
carterkozak
reviewed
Oct 4, 2022
| // Should never hit the following. | ||
| throw new SafeIllegalArgumentException( | ||
| "Illegal version format. This is a bug", SafeArg.of("version", version())); | ||
| } |
There was a problem hiding this comment.
We should probably update this to use immutables params and avoid the Agent.Builder altogether
carterkozak
reviewed
Oct 4, 2022
| .from(base) | ||
| .addAllInformational(additional) | ||
| .build(); | ||
| } |
There was a problem hiding this comment.
This is a bit odd given other factory methods live in the UserAgent class, however those don't take a base UserAgent.
There was a problem hiding this comment.
good call, not sure why I put it in UserAgents instead of with other factories in UserAgent.
I'm not sure if using @Value.Parameter buys us a ton in terms of either few allocations or readability as we don't currently include Guava in the service-config module, so no cheap Iterables.concat:
static UserAgent of(UserAgent base, Iterable<Agent> additional) {
return ImmutableUserAgent.of(
base.nodeId(),
base.primary(),
Stream.concat(base.informational().stream(), StreamSupport.stream(additional.spliterator(), false))
.collect(Collectors.toList()));
}
|
👍 |
|
Released 2.29.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
Creating a
UserAgentwith multiple additional informational agents required several immutable object creations. See palantir/dialogue#1797 for exampleAfter this PR
==COMMIT_MSG==
Add UserAgents.of(UserAgent, Iterable)
==COMMIT_MSG==
Possible downsides?