Skip to content

Optimize UserAgents.format #551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 18, 2020
Merged

Optimize UserAgents.format #551

merged 3 commits into from
May 18, 2020

Conversation

@carterkozak
Copy link
Contributor

==COMMIT_MSG==
Optimize UserAgents.format
==COMMIT_MSG==

@carterkozak carterkozak requested review from ferozco and iamdanfox May 18, 2020 16:32
@changelog-app
Copy link

changelog-app bot commented May 18, 2020 •
edited by carterkozak
Loading

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Optimize UserAgents.format

Check the box to generate changelog(s)

  • Generate changelog entry

iamdanfox
iamdanfox approved these changes May 18, 2020
View reviewed changes
Copy link
Contributor

@iamdanfox iamdanfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, should give us an instant perf boost (before we land the endpoint channel stuff in dialogue)

@carterkozak
Copy link
Contributor Author

🤖 🍿

@bulldozer-bot bulldozer-bot bot merged commit 635f3a5 into develop May 18, 2020
@bulldozer-bot bulldozer-bot bot deleted the ckozak/efficient_user_agent_formatting branch May 18, 2020 16:50
@svc-autorelease
Copy link
Collaborator

Released 2.13.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iamdanfox iamdanfox iamdanfox approved these changes

@ferozco ferozco Awaiting requested review from ferozco

Assignees

No one assigned

Labels

autorelease merge when ready

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@carterkozak @svc-autorelease @iamdanfox