[fix] SerializableError#asConjure() handles both remoting2 and remoting3 JSON keys #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamdanfox
force-pushed
the
fix-asConjure-method
branch
from
18343fd to
be1730f
Compare
qinfchen
reviewed
Sep 10, 2018
| } | ||
|
|
||
| @Test | ||
| public void asConjure_converts_json_with_both_remoting2_and_remoting3_fields() throws IOException { |
There was a problem hiding this comment.
also include parameters and errorInstanceId?
can we do what we did with the new maven coordinates before the switch? |
qinfchen
approved these changes
Sep 10, 2018
|
My plan for publishing is to temporarily rename the repo from conjure-java-runtime-api -> http-remoting-api re-do the bintray tokens, tag a release, then rename back to conjure-java-runtime-api and reset the tokens. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
asConjure would return a broken result if a server returns json with both remoting2 and remoting2 types, e.g.:
{ "errorCode":"CONFLICT", "errorName":"Product:TransactionConflict", "errorInstanceId":"7d345390-e41d-49dd-8dcb-38dd716c0347", "parameters":{}, "exceptionClass":"CONFLICT", "message":"Refer to the server logs with this errorInstanceId: 7d345390-e41d-49dd-8dcb-38dd716c0347" }It would translate this into the broken:
{ "errorCode":"CONFLICT", "errorName":"Refer to the server logs with this errorInstanceId: 7d345390-e41d-49dd-8dcb-38dd716c0347", "errorInstanceId":"7d345390-e41d-49dd-8dcb-38dd716c0347", "parameters":{} }After this PR
It translates it into the correct SerializableError.
Open questions