Skip to content

Add type check for Overlay focus element. #3936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 21, 2020
Merged

Add type check for Overlay focus element. #3936

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/core/src/components/overlay/overlay.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,6 +437,7 @@ export class Overlay extends AbstractPureComponent2<IOverlayProps, IOverlayState
if (
this.props.enforceFocus &&
this.containerElement != null &&
e.target instanceof Node &&
!this.containerElement.contains(e.target as HTMLElement)
) {
// prevent default focus behavior (sometimes auto-scrolls the page)
Expand Down