Skip to content

Add htmlTitle prop to Icon #3216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 6, 2018
Merged

Add htmlTitle prop to Icon #3216

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
319da39
add htmlTitle prop to Icon
gabeboning Dec 5, 2018
985ecc9
try to kick circleci?
gabeboning Dec 5, 2018
620f5c1
Merge remote-tracking branch 'blueprint/develop' into title-attr
gabeboning Dec 5, 2018
afaf713
comment update & backticks
gabeboning Dec 6, 2018
2dea3ee
add "on hover"
giladgray Dec 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/core/src/components/icon/icon.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,12 @@ export interface IIconProps extends IIntentProps, IProps {
*/
color?: string;

/**
* String for the `title` attribute on the rendered element, which will appear
* on hover as a native browser tooltip.
*/
htmlTitle?: string;

/**
* Name of a Blueprint UI icon, or an icon element, to render. This prop is
* required because it determines the content of the component, but it can
Expand Down Expand Up @@ -84,6 +90,7 @@ export class Icon extends React.PureComponent<IIconProps & React.DOMAttributes<H
const {
className,
color,
htmlTitle,
iconSize = Icon.SIZE_STANDARD,
intent,
title = icon,
Expand All @@ -100,7 +107,7 @@ export class Icon extends React.PureComponent<IIconProps & React.DOMAttributes<H
const viewBox = `0 0 ${pixelGridSize} ${pixelGridSize}`;

return (
<TagName {...htmlprops} className={classes}>
<TagName {...htmlprops} className={classes} title={htmlTitle}>
<svg fill={color} data-icon={icon} width={iconSize} height={iconSize} viewBox={viewBox}>
{title && <desc>{title}</desc>}
{paths}
Expand Down