Skip to content

Conversation

@giladgray
Copy link
Contributor

@giladgray giladgray commented Oct 26, 2016

  • karma
  • mocha
  • did not update istanbul-instrumenter-loader cuz it breaks everything (including itself?)
    • goes to 1.0.0 and seems to work very differently
    • code coverage numbers change considerably, and the reporters fail internally
    • so... no go.

Gilad Gray added 3 commits October 25, 2016 17:52
- didn't update istanbul-instrumenter-loader cuz it breaks everything (including itself?)
- removes a few obnoxious packages like jade
@giladgray giladgray changed the title update Karma NPM deps update test NPM deps Oct 26, 2016
@giladgray
Copy link
Contributor Author

update mocha to 3.x | Preview
core coverage | datetime coverage

@giladgray
Copy link
Contributor Author

add note explaing why sinon comes from tsd | Preview
core coverage | datetime coverage

@cyu06 cyu06 added the PR +1 label Oct 26, 2016
@giladgray giladgray merged commit e794ecc into master Oct 26, 2016
@giladgray giladgray deleted the gg/npm-update-test branch October 26, 2016 17:34
peterblazejewicz pushed a commit to peterblazejewicz/blueprint that referenced this pull request Dec 20, 2017
johnwiseheart pushed a commit to johnwiseheart/blueprint that referenced this pull request Dec 10, 2019
# This is the 1st commit message:

Fix yarn.lock

# This is the commit message palantir#2:

Fix yarn.lock

# This is the commit message palantir#3:

Compile blueprint rules

# This is the commit message palantir#4:

Rerun yarn

# This is the commit message palantir#5:

Yarn please

# This is the commit message palantir#6:

I think this is broken
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants