-
Notifications
You must be signed in to change notification settings - Fork 357
Add support for multiple applications of the same table in a pipeline #1301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add support for multiple applications of the same table in a pipeline #1301
Conversation
|
I have not looked at the code changes in detail yet. It would be great if you were able to get all CI build & tests passing before we go through code review. Feel free to ask questions about how to do that if you get stuck, but I would start by looking at the section "Some checks were not successful" on the PR's web page here: #1301, and clicking on the names of tests that are failing to see the logs. Try to determine why the tests are failing, and in some cases it is helpful if you can reproduce the failures on your local development system, too. |
|
Sure sir, I’ll do it. I will follow your instructions and reach out if I face any difficulties. I will check the workflow as well. |
7c9a1bf to
f8dd62b
Compare
|
It is not clear to me why the CI tests all show status "Exepcted - Waiting for status to be reported" when the last commit to this PR was yesterday. It seems either they never started, or they started and are "hung" somehow. It would be nice to see the CI test results for these proposed changes before reviewing them in detail. @sudhanshu112233shukla One way to "kick" the CI process is to add another commit to the PR. That usually causes CI tests to be started again. In this particular case, I noticed that your PR removed the file Dockerfile. That is not required for your changes, is it? If not, that file should not be removed by the PR. Pushing another commit to this PR that restores the existence of that file in the repo would be one way to make CI tests run again. Alternately, any simple inconsequential whitespace-only change in a README or a comment is another way. |
Sure sir I'll recover the file. |
I assume security feature since it is a first-time contributor or someone without write permissions (using a fork) editing CI workflow files. Let me check our settings but I do not think we can manually run them here... |
@sudhanshu112233shukla Do you need the changes to the github workflow test.yaml file in order to run CI on your changed version of the code? I did not try to understand them all, but some of them appeared to be copying log or other output files around. If they are helpful for debugging build failures, but are not otherwise needed for build to succeed, I'd recommend keeping a local copy of those changes on your system, but removing them from this PR, to see if doing so will enable the CI tests to run. |
|
@jafingerhut Sure sir I will do it... |
2071348 to
7197ef2
Compare
029a25d to
d0a333f
Compare
Signed-off-by: sudhanshu shukla <[email protected]> Signed-off-by: sudhanshu112233shukla <[email protected]>
Signed-off-by: sudhanshu shukla <[email protected]> Signed-off-by: sudhanshu112233shukla <[email protected]>
Signed-off-by: sudhanshu shukla <[email protected]> Signed-off-by: sudhanshu112233shukla <[email protected]>
Signed-off-by: sudhanshu shukla <[email protected]> Signed-off-by: sudhanshu112233shukla <[email protected]>
Signed-off-by: sudhanshu shukla <[email protected]> Signed-off-by: sudhanshu112233shukla <[email protected]>
Signed-off-by: sudhanshu shukla <[email protected]> Signed-off-by: sudhanshu112233shukla <[email protected]>
Signed-off-by: sudhanshu shukla <[email protected]> Signed-off-by: sudhanshu112233shukla <[email protected]>
Signed-off-by: sudhanshu shukla <[email protected]> Signed-off-by: sudhanshu112233shukla <[email protected]>
Signed-off-by: sudhanshu shukla <[email protected]> Signed-off-by: sudhanshu112233shukla <[email protected]>
Signed-off-by: sudhanshu shukla <[email protected]> Signed-off-by: sudhanshu112233shukla <[email protected]>
Signed-off-by: sudhanshu shukla <[email protected]> Signed-off-by: sudhanshu112233shukla <[email protected]>
Signed-off-by: sudhanshu shukla <[email protected]> Signed-off-by: sudhanshu112233shukla <[email protected]>
Signed-off-by: sudhanshu shukla <[email protected]> Signed-off-by: sudhanshu112233shukla <[email protected]>
Signed-off-by: sudhanshu shukla <[email protected]> Signed-off-by: sudhanshu112233shukla <[email protected]>
Signed-off-by: sudhanshu shukla <[email protected]> Signed-off-by: sudhanshu112233shukla <[email protected]>
…cker" This reverts commit c0276ba. Signed-off-by: sudhanshu shukla <[email protected]> Signed-off-by: sudhanshu112233shukla <[email protected]>
Signed-off-by: sudhanshu shukla <[email protected]> Signed-off-by: sudhanshu112233shukla <[email protected]>
Signed-off-by: sudhanshu shukla <[email protected]> Signed-off-by: sudhanshu112233shukla <[email protected]>
Signed-off-by: sudhanshu shukla <[email protected]> Signed-off-by: sudhanshu112233shukla <[email protected]>
Signed-off-by: sudhanshu shukla <[email protected]> Signed-off-by: sudhanshu112233shukla <[email protected]>
Signed-off-by: sudhanshu shukla <[email protected]> Signed-off-by: sudhanshu112233shukla <[email protected]>
Signed-off-by: sudhanshu112233shukla <[email protected]>
…ild improvements from both branches Signed-off-by: sudhanshu112233shukla <[email protected]>
Signed-off-by: sudhanshu112233shukla <[email protected]>
68eb865 to
05348a8
Compare
Description
This PR implements support for applying the same table multiple times in a pipeline while maintaining backward compatibility with existing JSON formats.
Fixes #1286
Key Changes
table_apply.handtable_apply.cppto implement the TableApply class that represents a specific application of a table in the control flowBackward Compatibility
This implementation maintains full backward compatibility with existing JSON formats (version 2.x). The code checks the JSON version and only processes table_applies for version 3.0+. Legacy JSON files will continue to work without modification.
Testing
Documentation