oxide: update to omicron version 53aea85 #304
Merged
+688
−216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudomateo
commented
Jul 18, 2025
Updated Omicron to oxidecomputer/omicron@53aea85. This pulls in the updating VPC firewall rules enums from oxidecomputer/omicron#8194.
sudomateo
force-pushed
the
sudomateo/oqlsoztoluos
branch
from
08dfbac to
7255536
Compare
karencfv
reviewed
Jul 20, 2025
Collaborator
karencfv
left a comment
karencfv
left a comment
There was a problem hiding this comment.
Thanks a bunch for taking this on! 🙇♀️
Just left a tiny note about testing, but otherwise looks good!
sudomateo
added a commit
to oxidecomputer/terraform-provider-oxide
that referenced
this pull request
Jul 21, 2025
Pulled in the Go SDK changes from oxidecomputer/oxide.go#304 which contained changes to the VPC firewall rules APIs. Updated the `oxide_vpc_firewall_rules` resource to account for these changes.
karencfv
approved these changes
Jul 21, 2025
Collaborator
karencfv
left a comment
karencfv
left a comment
There was a problem hiding this comment.
Thanks for the additional testing!
sudomateo
added a commit
to oxidecomputer/terraform-provider-oxide
that referenced
this pull request
Jul 24, 2025
Pulled in the Go SDK changes from oxidecomputer/oxide.go#304 which contained changes to the VPC firewall rules APIs. Updated the `oxide_vpc_firewall_rules` resource to account for these changes.
sudomateo
added a commit
to oxidecomputer/terraform-provider-oxide
that referenced
this pull request
Jul 24, 2025
Pulled in the Go SDK changes from oxidecomputer/oxide.go#304 which contained changes to the VPC firewall rules APIs. Updated the `oxide_vpc_firewall_rules` resource to account for these changes.
sudomateo
added a commit
to oxidecomputer/terraform-provider-oxide
that referenced
this pull request
Jul 24, 2025
Pulled in the Go SDK changes from oxidecomputer/oxide.go#304 which contained changes to the VPC firewall rules APIs. Updated the `oxide_vpc_firewall_rules` resource to account for these changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Omicron to oxidecomputer/omicron@53aea85. This pulls in the updating VPC firewall rules enums from oxidecomputer/omicron#8194.