[nexus] rename webhook alert headers #8195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Somehow, while working on renaming "webhook events" to "alerts" in PR #8169, I managed to overlook the names of the headers `x-oxide-event-id` and `x-oxide-event-class` that we set on webhook delivery requests. These should probably also be renamed to `alert`, so I did that. I also renamed `x-oxide-webhook-id` to `x-oxide-alert-id`, as that seemed clearer.
ahl
approved these changes
May 21, 2025
david-crespo
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow, while working on renaming "webhook events" to "alerts" in PR #8169, I managed to overlook the names of the headers
x-oxide-event-idandx-oxide-event-classthat we set on webhook deliveryrequests. These should probably also be renamed to
alert, so I did that. I also renamedx-oxide-webhook-idtox-oxide-alert-id, as that seemed clearer.