sim-sp: move version and caboose-related info to update module #8055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkw
added a commit
that referenced
this pull request
Apr 28, 2025
This necessitates moving the construction of `SpUpdate` earlier in the sim Gimlet initialization, so that the ereport state can ask it for Hubris version metadata. Now, it has to be constructed in `Gimlet::spawn` and passed in to `UdpTask::new` (and thus `Handler::new`), rather than constructed isnide `Handler::new`, so that the ereport state can also be passed in to `Handler::new`. @dap, let me know what you think of this --- if you base additional changes on code with the current factoring, it will probably make the eventual merge conflicts between our branches much more unpleasant, so maybe we can pull this out and land it separately, and have my branch depend on that? Let me know what you think!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just an internal refactoring in prep for the next step, which is updating this information during the update process.
There should be only two functional changes here, both minimal:
namefield in RoT cabooses used to beSimGimletRotfor Gimlets andSimSidecarfor Sidecars. I changed the sidecar one toSimSidecarRoTfor consistency.rot-boot-detailsused to report different information thanstatedid (e.g., different fwid). Now they're the same.