Skip to content

should validate hardcoded kernel structure info #7910

@iximeow

Description

@iximeow

in #7837 I added this mild crime of just writing in the size of a page_t in service of estimating how much memory OS allocations would account for in a fully-loaded sled. if page_t changes, this will become wrong.

from a quick skim, there's also dk_minfo_ext which is quite stable, but we don't have anything to validate this (or other, if there are other kernel structs we use in Omicron) is actually correct.

in the page_t case it hasn't changed in 20 years, and I see no reason to expect it to change soon. this is very low priority. but we tossed some ideas around and tried some stuff in this conversation thread - ctest2 has some wrinkles here, walking CTF at runtime might be better, or if we extract illumos bindings into a more standalone crate that might be more amenable to ctest2 as well.

either way this is pretty low priority.

Metadata

Metadata

Assignees

No one assigned

    Labels

    cleanupCode cleanliness

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions