feat(linter): add react/no-redundant-should-component-update rule

[baevm]

adds react/no-redundant-should-component-update, issue #1022

rule doc
rule source code

[graphite-app]

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

[Copilot]

Pull request overview

This PR adds the react/no-redundant-should-component-update lint rule that detects redundant shouldComponentUpdate method definitions in classes extending React.PureComponent. Since PureComponent already provides a shallow prop and state comparison via shouldComponentUpdate, defining this method explicitly is redundant and defeats the purpose of using PureComponent.

Key changes:

• Implements the rule to detect classes extending React.PureComponent or PureComponent with shouldComponentUpdate methods
• Handles both method definitions and arrow function property assignments
• Supports named and anonymous classes, including variable declarators

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.

File	Description
crates/oxc_linter/src/rules/react/no_redundant_should_component_update.rs	New rule implementation with logic to detect redundant shouldComponentUpdate in PureComponent classes
crates/oxc_linter/src/rules.rs	Registers the new rule module and adds it to the rules list
crates/oxc_linter/src/generated/rule_runner_impls.rs	Auto-generated runner implementation for the new rule
crates/oxc_linter/src/snapshots/react_no_redundant_should_component_update.snap	Test snapshot showing expected diagnostic outputs

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The rule is missing the should_run method that checks if the source file is JSX. All React rules in this codebase implement should_run to skip non-JSX files for performance. Add this method after the run method:\n\nrust\nfn should_run(&self, ctx: &ContextHost) -> bool {\n ctx.source_type().is_jsx()\n}\n\n\nYou'll also need to import ContextHost in the imports section.

[Copilot]

The import is missing ContextHost which is needed for the should_run method implementation. Update the import to:\n\nrust\nuse crate::{AstNode, context::{ContextHost, LintContext}, rule::Rule};\n

Suggested change

	use crate::{AstNode, context::LintContext, rule::Rule};
	use crate::{AstNode, context::{ContextHost, LintContext}, rule::Rule};

[codspeed-hq]

CodSpeed Performance Report

Merging #16147 will not alter performance

_{Comparing baevm:react/no-redundant-should-component-update (dba5c3a) with main (0549ae5)¹}

Summary

✅ 4 untouched
⏩ 41 skipped²

Footnotes

1. No successful run was found on main (9317ebc) during the generation of this report, so 0549ae5 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

2. 41 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩