Skip to content

feat(linter): add unicorn/prefer-bigint-literals rule #15923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 21, 2025
Merged

feat(linter): add unicorn/prefer-bigint-literals rule #15923

merged 3 commits into from
Nov 21, 2025
+399 −0

Conversation

@MichielVrins
Copy link
Contributor

@MichielVrins MichielVrins commented Nov 20, 2025

This PR adds unicorn/prefer-bigint-literals rule, issue #684

rule doc
rule source

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 20, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-linter Area - Linter C-enhancement Category - New feature or request labels Nov 20, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 21, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #15923 will not alter performance

Comparing MichielVrins:unicorn/prefer-bigint-literals (f06d343) with main (50461d7)1

Summary

✅ 4 untouched
⏩ 41 skipped2

Footnotes

  1. No successful run was found on main (22e132d) during the generation of this report, so 50461d7 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

  2. 41 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@camc314 camc314 force-pushed the unicorn/prefer-bigint-literals branch from 7edde3f to 4eead1d Compare November 21, 2025 14:40
camc314
camc314 approved these changes Nov 21, 2025
View reviewed changes
Copy link
Contributor

@camc314 camc314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@camc314
small refactor
f06d343 
This commit:
 - run `cargo lintgen` to update the generated code
 - remove the use of regex to improve performance
 - restructures the file to follow some common standards
@camc314 camc314 force-pushed the unicorn/prefer-bigint-literals branch from 4eead1d to f06d343 Compare November 21, 2025 14:40
@camc314 camc314 self-assigned this Nov 21, 2025
@camc314 camc314 merged commit a21f9e4 into oxc-project:main Nov 21, 2025
21 checks passed
Copilot AI pushed a commit that referenced this pull request Nov 21, 2025
@MichielVrins @camc314
feat(linter): implement unicorn/prefer-bigint-literals rule (#15923)
9e6f376 
This PR adds unicorn/prefer-bigint-literals rule, issue
#684

[rule
doc](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/v62.0.0/docs/rules/prefer-bigint-literals.md)
[rule
source](https://raw.githubusercontent.com/sindresorhus/eslint-plugin-unicorn/main/test/prefer-bigint-literals.js)

---------

Co-authored-by: Cameron Clark <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camc314 camc314 camc314 approved these changes

Assignees

@camc314 camc314

Labels

A-linter Area - Linter C-enhancement Category - New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MichielVrins @camc314