Skip to content

Conversation

@Sysix
Copy link
Member

@Sysix Sysix commented Nov 19, 2025

No description provided.

@github-actions github-actions bot added A-editor Area - Editor and Language Server C-test Category - Testing. Code is missing test cases, or a PR is adding them labels Nov 19, 2025
Copy link
Member Author

Sysix commented Nov 19, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Sysix Sysix force-pushed the 11-19-test_vscode_testsetup_for_oxfmt_--lsp_server branch from 08c84f2 to 0c703c9 Compare November 19, 2025 20:12
@Sysix Sysix marked this pull request as ready for review November 19, 2025 20:31
@Sysix Sysix requested a review from camc314 as a code owner November 19, 2025 20:31
Copilot AI review requested due to automatic review settings November 19, 2025 20:31
Copilot finished reviewing on behalf of Sysix November 19, 2025 20:33
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds test setup for the oxfmt --lsp server by creating a new test configuration that runs with the oxfmt LSP server instead of the main language server or oxlint server. The changes enable proper test isolation so that linter-specific tests can be skipped when testing the formatter-only server.

Key Changes:

  • New test configuration in .vscode-test.mjs for oxfmt --lsp tests with SKIP_LINTER_TEST environment variable
  • Build scripts added for oxfmt in package.json and CI workflow
  • Test suites conditionally skip based on SKIP_LINTER_TEST to avoid running linter tests against the formatter-only server

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
editors/vscode/.vscode-test.mjs Adds new oxfmt --lsp test configuration that sets SKIP_LINTER_TEST and points to oxfmt CLI
editors/vscode/tests/e2e_server_linter.spec.ts Adds conditional skip for linter test suite when SKIP_LINTER_TEST is enabled
editors/vscode/tests/code_actions.spec.ts Adds conditional skip for code actions test suite when SKIP_LINTER_TEST is enabled
editors/vscode/tests/commands.spec.ts Conditionally includes oxc.fixAll command in expected commands list and skips its test when SKIP_LINTER_TEST is enabled
editors/vscode/tests/e2e_server_formatter.spec.ts Adds workspace.saveAll() calls after config updates and adjusts timing of sleep in config path test for better synchronization
editors/vscode/package.json Adds oxfmt:build:debug and oxfmt:build:release scripts for building oxfmt with NAPI
.github/workflows/ci_vscode.yml Adds oxfmt/src/lsp/** to CI trigger paths and includes oxfmt build step in CI workflow

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-editor Area - Editor and Language Server C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants