travis ci with flake8 #68
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
awesome! this gets everything on to the same page WRT to styling :) will hopefully have time to take a deeper look tonight |
Collaborator
|
Looks good - both the .travis.yml and the lints. Next time please put 2 different things like Travis integration and style fixes in 2 different PRs. Altghough I understand the travis logic is doing the flakes check, so in this case it makes some sense. |
Owner
This is my fault, I set a bad precedent by using my linter inconsistently. :P |
Owner
Owner
|
closing due to #72 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#63
Pep8ify code and configure continuous check with Travis CI (thanks @t0mk for template).
Max-line-length set at 120.