Skip to content

Conversation

@rehmansheikh222
Copy link
Collaborator

@rehmansheikh222 rehmansheikh222 commented Sep 16, 2025

This PR closes #63

This is a breaking change as we are migrating from using DEFAULT_FILE_STORAGE to STORAGES as the same migration has been made in the edx-platform repo https://github.com/openedx/edx-platform/pull/37002/files

Copy link
Contributor

@Danyal-Faheem Danyal-Faheem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add a changelog entry signifying that this is a breaking change?

nit: Lets also add a detailed commit message signifying that this is a breaking change and a better PR description

@DawoudSheraz DawoudSheraz moved this from Pending Triage to In review in Tutor project management Sep 17, 2025
@DawoudSheraz
Copy link
Contributor

Can you also add a changelog entry signifying that this is a breaking change?

nit: Lets also add a detailed commit message signifying that this is a breaking change and a better PR description

+1 to these comments. The commit should also mention that this is a breaking change (fix!)

@rehmansheikh222 rehmansheikh222 changed the title fix: Migrate to STORAGES from DEFAULT_FILE_STORAGE fix!: Migrate to STORAGES from DEFAULT_FILE_STORAGE Sep 17, 2025
@rehmansheikh222 rehmansheikh222 force-pushed the rehman/migrate-to-storages branch from 33c57e2 to a8c381d Compare September 17, 2025 06:22
@rehmansheikh222 rehmansheikh222 force-pushed the rehman/migrate-to-storages branch from a8c381d to 0fe1488 Compare September 17, 2025 09:42
@Danyal-Faheem Danyal-Faheem merged commit b5a5d31 into main Sep 18, 2025
2 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in Tutor project management Sep 18, 2025
@Danyal-Faheem Danyal-Faheem deleted the rehman/migrate-to-storages branch September 18, 2025 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

4 participants