Sprite Drawing Example #145
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sajattack
requested changes
Dec 30, 2023
| sceGuSwapBuffers(); | ||
| } | ||
|
|
||
| sceGuTerm(); |
Collaborator
There was a problem hiding this comment.
the loop above never exits so this is unused code
| } | ||
|
|
||
| #[allow(unreachable_code)] | ||
| unsafe fn psp_innermain() { |
Collaborator
There was a problem hiding this comment.
not everything in this function is unsafe. It might also be wise to try to make some safe wrappers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made a simple sprite drawing example based on different available resources. Requesting a review to make sure there were no unnecessary calls in the code (except the unreachable code at the end to make sure the user remembers to exit the context safely).