- 
                Notifications
    
You must be signed in to change notification settings  - Fork 70
 
feat: fallback arm64 to x64 architecture for win32 platform #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| 
           probably should throw warning letting user know this is emulating the x64 version with microsofts emulator and not actually using a native arm build, so as result it may be buggy. for example use the https://docs.github.com/en/actions/reference/workflow-commands-for-github-actions#setting-a-warning-message method so it shows up in the status page where they will see if it the workflow failed.  | 
    
          
 good idea 👍  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds a temporary workaround for missing ARM64 Windows builds of Bun by falling back to x64 and updates the CI matrix to include an ARM Windows runner.
- Introduce 
getEffectiveArchto maparm64→x64on Windows and emit a warning. - Update 
getDownloadUrlto usegetEffectiveArch. - Expand GitHub Actions matrix with 
windows-11-arm. 
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description | 
|---|---|
| src/action.ts | Add getEffectiveArch and integrate it into download URL encoding | 
| .github/workflows/test.yml | Add windows-11-arm to the list of test runners | 
Comments suppressed due to low confidence (5)
.github/workflows/test.yml:53
- The 
windows-11-armrunner label is not a standard GitHub-hosted runner and will cause CI failures. Replace it with a valid ARM runner label or use a self-hosted runner. 
          - windows-11-arm
.github/workflows/test.yml:92
- Duplicate invalid runner label here; CI will not recognize 
windows-11-arm. Consolidate or correct all occurrences. 
          - windows-11-arm
.github/workflows/test.yml:159
- This step also uses the non-existent 
windows-11-armrunner. Please ensure all matrix entries use valid runner names. 
          - windows-11-arm
src/action.ts:158
- There are no existing unit tests covering the new 
getEffectiveArchfallback behavior. Consider adding tests to verify Windows ARM64 is correctly remapped to x64 and the warning is emitted. 
function getEffectiveArch(os: string, arch: string): string {
src/action.ts:158
- [nitpick] Consider adding a JSDoc comment above 
getEffectiveArchto explain its purpose and parameters for future maintainers. 
function getEffectiveArch(os: string, arch: string): string {
| 
           blocked until the bug in bun's download api is fixed  | 
    
| 
           @xhyrom is this till blocked ? can it be re-triggered ? thanks !  | 
    
closes #130