Skip to content

Conversation

@xhyrom
Copy link
Collaborator

@xhyrom xhyrom commented Jul 10, 2025

closes #130

@xhyrom xhyrom requested a review from Copilot July 10, 2025 18:16

This comment was marked as outdated.

@RiskyMH
Copy link
Member

RiskyMH commented Jul 10, 2025

probably should throw warning letting user know this is emulating the x64 version with microsofts emulator and not actually using a native arm build, so as result it may be buggy.

for example use the https://docs.github.com/en/actions/reference/workflow-commands-for-github-actions#setting-a-warning-message method so it shows up in the status page where they will see if it the workflow failed.

@xhyrom
Copy link
Collaborator Author

xhyrom commented Jul 10, 2025

probably should throw warning letting user know this is emulating the x64 version with microsofts emulator and not actually using a native arm build, so as result it may be buggy.

for example use the https://docs.github.com/en/actions/reference/workflow-commands-for-github-actions#setting-a-warning-message method so it shows up in the status page where they will see if it the workflow failed.

good idea 👍

@xhyrom xhyrom requested a review from Copilot July 10, 2025 18:28
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds a temporary workaround for missing ARM64 Windows builds of Bun by falling back to x64 and updates the CI matrix to include an ARM Windows runner.

  • Introduce getEffectiveArch to map arm64x64 on Windows and emit a warning.
  • Update getDownloadUrl to use getEffectiveArch.
  • Expand GitHub Actions matrix with windows-11-arm.

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
src/action.ts Add getEffectiveArch and integrate it into download URL encoding
.github/workflows/test.yml Add windows-11-arm to the list of test runners
Comments suppressed due to low confidence (5)

.github/workflows/test.yml:53

  • The windows-11-arm runner label is not a standard GitHub-hosted runner and will cause CI failures. Replace it with a valid ARM runner label or use a self-hosted runner.
          - windows-11-arm

.github/workflows/test.yml:92

  • Duplicate invalid runner label here; CI will not recognize windows-11-arm. Consolidate or correct all occurrences.
          - windows-11-arm

.github/workflows/test.yml:159

  • This step also uses the non-existent windows-11-arm runner. Please ensure all matrix entries use valid runner names.
          - windows-11-arm

src/action.ts:158

  • There are no existing unit tests covering the new getEffectiveArch fallback behavior. Consider adding tests to verify Windows ARM64 is correctly remapped to x64 and the warning is emitted.
function getEffectiveArch(os: string, arch: string): string {

src/action.ts:158

  • [nitpick] Consider adding a JSDoc comment above getEffectiveArch to explain its purpose and parameters for future maintainers.
function getEffectiveArch(os: string, arch: string): string {

@xhyrom xhyrom added the blocked label Jul 10, 2025
@xhyrom
Copy link
Collaborator Author

xhyrom commented Jul 10, 2025

blocked until the bug in bun's download api is fixed

@ericLemanissier
Copy link

@xhyrom is this till blocked ? can it be re-triggered ? thanks !

@xhyrom
Copy link
Collaborator Author

xhyrom commented Jul 21, 2025

@xhyrom is this till blocked ? can it be re-triggered ? thanks !

this is still blocked because of bug in bun's download api, cc @RiskyMH

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

support windows arm

4 participants