Skip to content

FFmpeg WHIP: NACK - RTX patchset #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

FFmpeg WHIP: NACK - RTX patchset #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
81eddda
avformat/whip: add whip_flags ignore_ipv6 to skip IPv6 ICE candidates
JackLau1222 Jun 28, 2025
2c62b32
avformat/whip: reindent whip options
JackLau1222 Jun 28, 2025
22f5b1c
avformat/whip: fix typos
JackLau1222 Jun 28, 2025
fb68173
avformat/whip: fix H264 profile_iop bit map for SDP
JackLau1222 Jun 18, 2025
e6b049f
WHIP: X509 cert serial number should be positive.
winlinvip Jun 10, 2025
0e11ba6
avformat/whip: implement NACK and RTX suppport
murillo128 Jun 10, 2025
2a093ce
avformat/whip: add disable_nack_rtx flag
JackLau1222 Jul 2, 2025
403d36e
avformat/whip: only support disable rtx for now
JackLau1222 Jul 2, 2025
748b114
avformat/whip: fix typos
JackLau1222 Jul 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libavformat/tls.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ int ff_tls_open_underlying(TLSShared *c, URLContext *parent, const char *uri, AV
parent->protocol_whitelist, parent->protocol_blacklist, parent);
if (c->is_dtls) {
if (ret < 0) {
av_log(c, AV_LOG_ERROR, "WHIP: Failed to connect udp://%s:%d\n", c->underlying_host, port);
av_log(c, AV_LOG_ERROR, "Failed to connect udp://%s:%d\n", c->underlying_host, port);
return ret;
}
/* Make the socket non-blocking, set to READ and WRITE mode after connected */
Expand Down
3 changes: 2 additions & 1 deletion libavformat/tls_openssl.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,8 @@ static int openssl_gen_certificate(EVP_PKEY *pkey, X509 **cert, char **fingerpri
goto enomem_end;
}

serial = (int)av_get_random_seed();
// According to RFC5280 4.1.2.2, The serial number MUST be a positive integer
serial = (int)(av_get_random_seed() & 0x7FFFFFFF);
if (ASN1_INTEGER_set(X509_get_serialNumber(*cert), serial) != 1) {
av_log(NULL, AV_LOG_ERROR, "TLS: Failed to set serial, %s\n", ERR_error_string(ERR_get_error(), NULL));
goto einval_end;
Expand Down
Loading
Loading