Update READ with more stuff #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More stuff is cool
|
This looks ok - could you add unite test |
ghost
assigned
|
not needed |
Closed
atomicturtle
pushed a commit
that referenced
this pull request
Apr 28, 2016
Minor fixes to case / grammar in README.md
Closed
ddpbsd
pushed a commit
that referenced
this pull request
Jan 5, 2017
This PR fixes the following Windows-related build issues: S_ISLNK usage S_ISLNK isn't a supported call on Windows due to the lack of filesystem links like they exist on Unix-based systems. Other parts of the code properly check if WIN32 is defined, however, one piece was overlooked. This is fixed in one of the commits in this PR. MINGW_HAS_SECURE_API Incorrectly Used The MINGW_HAS_SECURE_API was used incorrectly and broke the Windows build - the correct usage is to define this to '1' instead of just defining it, as evident in the mingw headers. Add Windows-specific output to .gitignore Some of the build output files aren't added to the .gitignore, causing a potential source tree pollution when committing to the repository. Most notably, there was no exclusion for *.exe and *.dll files, while there was an exclusion for .so files. This discrepancy has been corrected.
atomicturtle
pushed a commit
that referenced
this pull request
Jan 6, 2021
* Fix compiling and suspend warnings in read_journald.c * Add READING_JOURNAL #define for debug printing in logcollector * Add 'journald' as allowed XML config parameter for 'logformat'
atomicturtle
pushed a commit
that referenced
this pull request
Aug 9, 2023
add parental rule id for rule 52000
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More stuff is cool