Improve stability of tests in PolyhedralGeometry #4197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgoettgens
added
the
topic: polyhedral geometry
|
This unfortunately has a conflict |
alexej-jordan
force-pushed
the
aj/test-order
branch
from
4d4e33e to
89121e1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4197 +/- ##
==========================================
- Coverage 84.60% 84.59% -0.02%
==========================================
Files 631 631
Lines 84939 85023 +84
==========================================
+ Hits 71864 71921 +57
- Misses 13075 13102 +27
|
…applied to test/polyhedron.jl
…nd RayVector now throws an error
alexej-jordan
force-pushed
the
aj/test-order
branch
from
ec55878 to
f27a035
Compare
benlorenz
reviewed
Oct 18, 2024
benlorenz
reviewed
Oct 21, 2024
benlorenz
approved these changes
Oct 23, 2024
lkastner
approved these changes
Oct 24, 2024
HechtiDerLachs
pushed a commit
to HechtiDerLachs/Oscar.jl
that referenced
this pull request
Oct 30, 2024
* introduced helper functions for stable tests in polyhedral geometry, applied to test/polyhedron.jl * increased stability for cone tests * increased stability for extended tests * increased stability for polyhedral_fan tests * increased stability for scalar_types tests * increased stability for polyhedral_complex tests * increased stability for subdivision_of_points tests * improved == for RayVector; forced RayVector != PointVector * fixed comparison between RayVectors; comparison between PointVector and RayVector now throws an error * fixed formatting for iterators.jl * added and adjusted commented test in cone.jl * increased code coverage for changes in iterators.jl * improved comparison between RayVectors * re-added test for matrix(ZZ, rays(Cone6)) * adjusted test for weights in subdivision_of_points.jl * improved comparison between RayVectors and added additional tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent tests from randomly failing if the order of some properties changes or rays are represented differently.