Rewrite get data to fix bug #293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinejespersen
force-pushed
the
feature/4905-rewrite-get-data-to-fix-bug
branch
from
913a396 to
47e3684
Compare
sinejespersen
force-pushed
the
feature/4905-rewrite-get-data-to-fix-bug
branch
2 times, most recently
from
da915d0 to
f606afc
Compare
tuj
requested changes
Sep 12, 2025
| apiCall({ | ||
| ...params, | ||
| page, | ||
| itemsPerPage: 10, |
There was a problem hiding this comment.
The max items per page is 30: https://github.com/os2display/display-api-service/blob/develop/config/packages/api_platform.yaml#L11
Let's fetch as many results as possible when fetching all.
|
|
||
| totalItems = hydraTotalItems; | ||
| fetchedItems = fetchedItems.concat(itemsWithOriginalArgs); | ||
| page++; |
There was a problem hiding this comment.
Instead of page++ iteration you can use the
"hydra:next"
When it is not set, there are no more pages.
sinejespersen
force-pushed
the
feature/4905-rewrite-get-data-to-fix-bug
branch
from
f606afc to
1c8560a
Compare
tuj
approved these changes
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket
https://leantime.itkdev.dk/TimeTable/TimeTable?showTicketModal=5276#/tickets/showTicket/4905
#283
Description
mapDataas it was impossible to remove itemsmap-to-ids.jshelper<PaginationButtonScreenshot of the result
🖼️