Skip to content

oradb_manage_db: bugfix for wrong IFILE path in tnsnames.ora and sqlnet.ora when readonly ORACLE_HOME is used #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2023
Merged

oradb_manage_db: bugfix for wrong IFILE path in tnsnames.ora and sqlnet.ora when readonly ORACLE_HOME is used #371

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelogs/fragments/ifile.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
---
bugfixes:
- "oradb_manage_db: bugfix for wrong IFILE path in tnsnames.ora and sqlnet.ora when readonly ORACLE_HOME is used (oravirt#371)"
6 changes: 3 additions & 3 deletions roles/oradb_manage_db/tasks/sqlnet.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@

- name: sqlnet.ora | create IFILE entry in sqlnet.ora
ansible.builtin.lineinfile:
line: "IFILE={{ listener_home_config }}/network/admin/sqlnet_ansible.ora"
line: "IFILE={{ _oradb_manage_db_tns_home }}/network/admin/sqlnet_ansible.ora"
regexp: "^IFILE=/"
insertbefore: BOF
path: "{{ listener_home_config }}/network/admin/sqlnet.ora"
path: "{{ _oradb_manage_db_tns_home }}/network/admin/sqlnet.ora"
backup: true
create: true
group: "{{ oracle_group }}"
Expand All @@ -19,7 +19,7 @@

- name: sqlnet.ora | create custom configuration in sqlnet_ansible.ora
ansible.builtin.lineinfile:
path: "{{ listener_home_config }}/network/admin/sqlnet_ansible.ora"
path: "{{ _oradb_manage_db_tns_home }}/network/admin/sqlnet_ansible.ora"
line: "{{ item.name }}={{ item.value }}"
regexp: "^{{ item.name }}="
backup: true
Expand Down
6 changes: 3 additions & 3 deletions roles/oradb_manage_db/tasks/tnsnames.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@

- name: tnsnames.ora | create IFILE entry in tnsnames.ora
ansible.builtin.lineinfile:
line: "IFILE={{ listener_home }}/network/admin/tnsnames_ansible.ora"
line: "IFILE={{ _oradb_manage_db_tns_home }}/network/admin/tnsnames_ansible.ora"
regexp: "^IFILE=/"
insertbefore: BOF
path: "{{ listener_home_config }}/network/admin/tnsnames.ora"
path: "{{ _oradb_manage_db_tns_home }}/network/admin/tnsnames.ora"
backup: true
create: true
group: "{{ oracle_group }}"
Expand All @@ -19,7 +19,7 @@

- name: tnsnames.ora | create custom configuration in tnsnames_ansible.ora
ansible.builtin.blockinfile:
path: "{{ listener_home_config }}/network/admin/tnsnames_ansible.ora"
path: "{{ _oradb_manage_db_tns_home }}/network/admin/tnsnames_ansible.ora"
backup: true
create: true
group: "{{ oracle_group }}"
Expand Down
8 changes: 8 additions & 0 deletions roles/oradb_manage_db/vars/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---

_oradb_manage_db_tns_loop_helper: "{{ tnsinst | default(sqlnetinst) | default({}) }}"

_oradb_manage_db_tns_home: |-
{%- if db_homes_config[_oradb_manage_db_tns_loop_helper.home]['readonly_home'] | default(false) %}
{{ oracle_base }}/homes/{{ db_homes_config[_oradb_manage_db_tns_loop_helper.home]['oracle_home_name'] }}
{%- else %}{{ listener_home_config }}{% endif -%}