Skip to content
This repository was archived by the owner on Jan 9, 2020. It is now read-only.

Conversation

drahnr
Copy link
Contributor

@drahnr drahnr commented Jun 22, 2019

Superseeds changes from #46 and #44 - recreated changes since I already signed the CLA

@vishvananda
Copy link
Contributor

looks like it needs a flag added to a crate to build on nightly From the wercker logs:

   Compiling strsim v0.8.0
   Compiling textwrap v0.11.0
error: use of unstable library feature 'ord_max_min' (see issue #25663)
   --> /root/.cargo/registry/src/github.com-1ecc6299db9ec823/strsim-0.8.0/src/lib.rs:190:59
    |
190 |     1.0 - (levenshtein(a, b) as f64) / (a.chars().count().max(b.chars().count()) as f64)
    |                                                           ^^^
    |
    = help: add #![feature(ord_max_min)] to the crate attributes to enable

musl seems to be broken for unrelated reasons

@drahnr
Copy link
Contributor Author

drahnr commented Jun 28, 2019

on my local machine nightly compiles just fine ( nightly-x86_64-unknown-linux-gnu unchanged - rustc 1.37.0-nightly (8ebd67e4e 2019-06-27) ), the error message of the wercker build does complain about the same issue as with the first commit, but f7e9e9f addresses that. Could you take a look at this?

@drahnr
Copy link
Contributor Author

drahnr commented Jul 5, 2019

Ping

@spacekookie
Copy link

lol it's a bit ridiculous that instead of just merging existing PRs you replicate stuff in new ones

@drahnr
Copy link
Contributor Author

drahnr commented Sep 9, 2019

lol it's a bit ridiculous that instead of just merging existing PRs you replicate stuff in new ones

I thought I expressed why this was done in the first place in the initial PR message - I signed the CLA, and I wanted to avoid low hanging fruits/chores being stalled by the lack of other people signing the CLA.

@spacekookie
Copy link

spacekookie commented Sep 9, 2019 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants