-
Notifications
You must be signed in to change notification settings - Fork 29
refactor!: remove the automatic sbom generation feature for Java #1145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5eb92e9
to
e930b66
Compare
For mvnw and gradlew used in SBOM generation, we mount
We probably don't need to mount them anymore. Removing these location also requires us to update
Some other locations: |
...gration/cases/apache_maven_local_path_with_branch_name_digest_deps_cyclonedx_maven/test.yaml
Show resolved
Hide resolved
Thanks for spotting the leftover references in |
See commit 5d13ecc. |
5d13ecc
to
481a08f
Compare
tests/integration/cases/example_maven_app_sbom_tutorial/dependencies.json
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have finished my first round of review.
aa63089
to
f8f5431
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the changes!
Signed-off-by: behnazh-w <[email protected]>
Signed-off-by: behnazh-w <[email protected]>
Signed-off-by: behnazh-w <[email protected]>
Signed-off-by: behnazh-w <[email protected]>
Signed-off-by: behnazh-w <[email protected]>
…al-maven-repo Signed-off-by: behnazh-w <[email protected]>
…tructions Signed-off-by: behnazh-w <[email protected]>
f8f5431
to
99973a1
Compare
Summary
This PR removes the automatic SBOM generation feature for Java projects in Macaron.
Description of changes
The automatic SBOM generation functionality for Java (via Maven and Gradle) has been removed from Macaron. This decision was made for the following reasons:
As part of this refactor:
cyclonedx-bom
andcyclonedx-python-lib[validation]
dependencies have been updated.$HOME/.m2
directory in the container is empty and no longer mounted or used by the Python package.Related issues
Closes #56
Closes #60