Skip to content

Conversation

christophstrobl
Copy link
Contributor

What does this PR do?

Add metadata for hibernate-core 7.1 which added a few new requirements for reflection configuration.

Checklist before merging

@christophstrobl christophstrobl requested a review from a team as a code owner September 3, 2025 15:33
@sdeleuze sdeleuze self-requested a review September 3, 2025 21:08
@sdeleuze
Copy link
Collaborator

sdeleuze commented Sep 3, 2025

Thanks @christophstrobl for this PR, I will review it asap.

@sdeleuze
Copy link
Collaborator

FYI ongoing discussion internally on how to fix one remaining issue.

Copy link
Collaborator

@sdeleuze sdeleuze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM expect a blocking point since we miss a JDK proxy entry (and related test) for the set of following classes:

  • org.hibernate.query.hql.spi.SqmQueryImplementor.class,
  • org.hibernate.query.sqm.spi.InterpretationsKeySource.class
  • org.hibernate.query.spi.DomainQueryExecutionContext.class
  • org.hibernate.query.SelectionQuery.class
  • org.hibernate.query.CommonQueryContract.class

Copy link
Collaborator

@sdeleuze sdeleuze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After another look, the missing hint is Spring specific and will be handled via spring-projects/spring-framework#35462, so this PR LGTM @dnestoro.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants