51 add getlastknowposition #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary - Implement getLastKnownPositions API method with proper pagination support - Add getAllLastKnownPositions method that automatically handles hasMore pagination - Include comprehensive TypeScript interfaces and type definitions - Add CLAUDE.md for future development guidance - Fix existing test suite issues for better reliability ## Implementation Details - getLastKnownPositions: Single API call with offset/resources parameters - getAllLastKnownPositions: Automatic pagination using hasMore flag - Proper TypeScript types with optional hasMore field for large responses - 14 comprehensive test cases covering all scenarios - Updated test configurations to match actual API responses ## Test Coverage - All parameter combinations (offset, resources, multiple resources) - Response structure validation and error handling - Pagination behavior and data accumulation - Invalid resource handling and edge cases 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Closed
oracle-contributor-agreement
bot
added
the
OCA Verified
btoron
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The branch 51-add-getlastknowposition has been successfully pushed to
oracle-samples/ofs-proxy-js. Here's the information for creating the pull request:
Branch Information:
Pull Request Details:
Title: Add getLastKnownPositions and getAllLastKnownPositions methods
Description:
Summary
getLastKnownPositionsAPI method with proper pagination supportgetAllLastKnownPositionsmethod that automatically handleshasMorepaginationImplementation Details
New Methods
getLastKnownPositions(params?): Single API call with optional offset/resourcesparameters
getAllLastKnownPositions(params?): Automatic pagination usinghasMoreflag fromOracle API
TypeScript Support
hasMorefield for large responses (>20MB)OFSGetLastKnownPositionsParamsinterface for input parametersOFSLastKnownPositioninterface for individual position dataOFSLastKnownPositionsResponseclass for typed responsesKey Features
Test Coverage
Added 14 comprehensive test cases covering:
Test Fixes