Skip to content

Fixing bulk merge #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Fixing bulk merge #23

wants to merge 7 commits into from

Conversation

aarrasseayoub01
Copy link
Member

@aarrasseayoub01 aarrasseayoub01 commented Aug 19, 2025

This fixes the issue #21
and fixes the following tests:

  • TestSingleTableHasManyAssociation
  • TestNestedManyToManyPreload3
  • TestNestedManyToManyPreload3ForStruct
  • TestHasManyAssociation
  • TestHasManyAssociationForSlice
  • TestPolymorphicHasManyAssociation
  • TestPolymorphicHasManyAssociationForSlice
  • TestSingleTableHasManyAssociationForSlice
  • TestHasManyAssociationReplaceWithNonValidValue
  • TestSingleTableMany2ManyAssociation
  • TestSingleTableMany2ManyAssociationForSlice
  • TestUpdateMany2ManyAssociations

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Aug 19, 2025
@@ -923,3 +946,29 @@ func handleLastInsertId(db *gorm.DB, result sql.Result) {
}
}
}
func sanitizeCreateValuesForBulkArrays(stmt *gorm.Statement, cv *clause.Values) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a blank line before this function and a brief comment explaining what it does?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants