Solnpool Updates #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reordering and documenting API
Use the Pyomo Bunch class as an alias for Munch, to avoid introducing an additional Pyomo dependency.
Avoiding use of KW_ONLY, which is an internal mechanism
Using new serialization API, which is simpler. :)
1. Reworking solver matrix logic 2. Fixing test to benchmark against the solution values
Added non-positive error check and value 1 warning for num_solutions in balas
Added num_solution error if num_solutions is non-positive, warning if num_solutions =1
Added checks and warnings for num_solutions as non-positive or 1 respectively
…de=1 Added num_solution checks and warnings for non-positive and 1 values respectively. Allowed PoolSearchMode=1 if users want, but included warning about unexpected behavior
Added checks to the policies supporting max_pool_size to error on non-positive pool size
The functionality to catch invalid policies already existed in PoolManager. Added the corresponding tests for invalid policies with and without extra arguments
Added methods to get the active pool name and the list of all pool names in the PoolManager and corresponding tests
Added the placeholder for the SolutionPoolBase so it can easily be retreived elsewhere without looking at the name of the subclass
Added methods to get the active pool and all pools policy and max_pool_sizes. Added corresponding tests
.pool -> .active_pool ._pool -> ._pools Stresses the active pool in use and the tools to touch on multiple pools
Old to_dict method worked on all pools, renamed get_pool_dicts New to_dict is pass through to active pool
Update the commenting documentation. The split between pool_config and metadata is now clearer with metadata containing information all SolutionPools have and pool_config is the class specific data.
Additional updates to enforce the metadata/pool_config data split We also now have pass through properties for all the not-private SolutionPool properties in PoolManager.
Added more test for pass through parameters and applied black to the files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
Summary/Motivation:
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: