fix: migrate apis directory to api per standard #6646
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redhatrises
force-pushed
the
api_dir_migration
branch
from
0e8d279 to
22d185e
Compare
- When multigroup is true, the api directory is now used instead of apis. Signed-off-by: Gabe Alford <[email protected]>
redhatrises
force-pushed
the
api_dir_migration
branch
from
22d185e to
9225257
Compare
Contributor
Author
|
@everettraven would you mind taking a look at this as a follow up to #6613 ? Thanks! |
everettraven
approved these changes
Jan 9, 2024
Contributor
everettraven
left a comment
everettraven
left a comment
There was a problem hiding this comment.
Thanks @redhatrises for this PR! Looks good to me!
/lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This appears to have been missed in the latest release which uses go/v4.