Skip to content

Conversation

@everettraven
Copy link
Contributor

@everettraven everettraven commented Jun 28, 2023

Description of the change:

  • Updates ansible to 2.15.0
  • Limits dependencies we manage by only including in the Pipfile:
    • ansible-core
    • ansible-runner
    • ansible-runner-http
    • kubernetes
    • urllib3 (need to pin this to a version <2 due to some issues encountered when running the testdata/ansible/memcached-operator with these changes)
  • Updates Python version to 3.9 (minimum supported by Ansible 2.15)
  • Updates CI to use new Python versions
  • Updates Ansible Operator scaffolding to remove the community.kubernetes collection (archived and replaced by kubernetes.core)
  • Updates Ansible Operator scaffolding to use the operator_sdk.util collection v0.5.0
  • Removes the ansible-2.11-preview image
  • Updates documentation around ansible base images to mention that after v1.30.0 base images will be based on ansible 2.15
  • Updates Ansible Operator scaffolding to use work with a newer version of molecule (v5.1.0)
  • Updates the base.Dockerfile to use multi-stage builds where Rust is installed before installing necessary python packages so that any architecture that may be missing prebuilt wheels can have the wheels built during the image build process.

A sample base image with these changes can be found at quay.io/rh_ee_bpalmer/ansible-operator:dev

Motivation for the change:

  • prevent users from using out of date and no longer supported ansible, python packages, and ansible collections

Checklist

If the pull request includes user-facing changes, extra documentation is required:

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 28, 2023
@everettraven everettraven temporarily deployed to deploy June 28, 2023 21:00 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy June 28, 2023 21:00 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy June 29, 2023 19:03 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy June 29, 2023 19:03 — with GitHub Actions Inactive
@everettraven everettraven changed the title WIP: remove the 'openshift' python package WIP: update ansible operator Jun 29, 2023
@everettraven everettraven temporarily deployed to deploy June 30, 2023 18:02 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy June 30, 2023 18:02 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy June 30, 2023 18:02 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy June 30, 2023 18:02 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy June 30, 2023 18:02 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy June 30, 2023 18:02 — with GitHub Actions Inactive
and the community.kubernetes collection that requires it

Signed-off-by: Bryce Palmer <[email protected]>
to only be what is absolutely necessary to get the memcached testdata operator to run

Signed-off-by: Bryce Palmer <[email protected]>
Signed-off-by: Bryce Palmer <[email protected]>
Signed-off-by: Bryce Palmer <[email protected]>
Signed-off-by: Bryce Palmer <[email protected]>
@everettraven everettraven temporarily deployed to deploy July 3, 2023 16:46 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy July 3, 2023 16:46 — with GitHub Actions Inactive
Signed-off-by: Bryce Palmer <[email protected]>
@everettraven everettraven marked this pull request as ready for review July 3, 2023 17:35
@everettraven everettraven temporarily deployed to deploy July 3, 2023 17:35 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy July 3, 2023 17:35 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy July 3, 2023 17:35 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy July 3, 2023 17:35 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy July 3, 2023 17:35 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy July 3, 2023 17:35 — with GitHub Actions Inactive
@openshift-ci openshift-ci bot requested review from asmacdo and oceanc80 July 3, 2023 17:35
@everettraven everettraven changed the title WIP: update ansible operator update ansible operator Jul 3, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 3, 2023
@oceanc80
Copy link
Collaborator

oceanc80 commented Jul 5, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 5, 2023
@everettraven everettraven merged commit 03136c0 into operator-framework:master Jul 10, 2023
PureRaidenCloud pushed a commit to PureRaidenCloud/operator-sdk that referenced this pull request Jul 18, 2023
* upgrade ansible->2.15, update managed dependencies
to only be what is absolutely necessary to get the memcached testdata operator to run
---------
Signed-off-by: Bryce Palmer <[email protected]>
Signed-off-by: PureRaidenCloud <[email protected]>
vkmc added a commit to infrawatch/service-telemetry-operator that referenced this pull request Oct 29, 2024
This change [0] in the ansible-operator introduced the
removal of both k8s and operator_sdk.util from the base image.
This means we now need to add the dependendencies ourselves
when building STO.

[0] operator-framework/operator-sdk#6483
vkmc added a commit to infrawatch/smart-gateway-operator that referenced this pull request Oct 29, 2024
This change [0] in the ansible-operator introduced the
removal of both k8s and operator_sdk.util from the base image.
This means we now need to add the dependendencies ourselves
when building SGO.

[0] operator-framework/operator-sdk#6483
vkmc added a commit to infrawatch/smart-gateway-operator that referenced this pull request Oct 29, 2024
This change [0] in the ansible-operator introduced the
removal of both k8s and operator_sdk.util from the base image.
This means we now need to add the dependendencies ourselves
when building SGO.

[0] operator-framework/operator-sdk#6483
vkmc added a commit to infrawatch/smart-gateway-operator that referenced this pull request Oct 29, 2024
This change [0] in the ansible-operator introduced the
removal of both k8s and operator_sdk.util from the base image.
This means we now need to add the dependendencies ourselves
when building SGO.

[0] operator-framework/operator-sdk#6483
vkmc added a commit to infrawatch/service-telemetry-operator that referenced this pull request Oct 29, 2024
This change [0] in the ansible-operator introduced the
removal of both k8s and operator_sdk.util from the base image.
This means we now need to add the dependendencies ourselves
when building STO.

[0] operator-framework/operator-sdk#6483
vkmc added a commit to infrawatch/service-telemetry-operator that referenced this pull request Oct 29, 2024
This change [0] in the ansible-operator introduced the
removal of both k8s and operator_sdk.util from the base image.
This means we now need to add the dependendencies ourselves
when building STO.

[0] operator-framework/operator-sdk#6483
vkmc added a commit to infrawatch/service-telemetry-operator that referenced this pull request Nov 5, 2024
* Use openshift-ansible-operator 4.17 in STO

* Use operator-framework/ansible-operator v1.35.0

Images for origin-ansible-operator are no longer
being published. We can use ansible-operator
directly.

ansible-operator v1.35.0 should replace
origin-ansible-operator v4.17

* Add ansible-galaxy requirements to STO

This change [0] in the ansible-operator introduced the
removal of both k8s and operator_sdk.util from the base image.
This means we now need to add the dependendencies ourselves
when building STO.

[0] operator-framework/operator-sdk#6483
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants