Skip to content

Conversation

@wasup-yash
Copy link
Contributor

Description of the change:
Updated Reference from " to_be_owned.namespace "
to " to_be_owned.metadata.namespace " at line 186.

Signed-off-by: wasup-yash [email protected]
Motivation for the change:
Closes #6318

Signed-off-by: Yash sharma <[email protected]>
@wasup-yash
Copy link
Contributor Author

@asmacdo @jberkhahn any updates on this PR ?

Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wasup-yash thanks for this contribution! Looks good to me!

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2023
@wasup-yash
Copy link
Contributor Author

@wasup-yash thanks for this contribution! Looks good to me!

/lgtm

Looking forward to more of it, any other issue which requires help with less of the code base understanding(still going through it)? so you can ping me XD

Copy link
Member

@rashmigottipati rashmigottipati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@everettraven
Copy link
Contributor

Looks like the checks on this PR got stuck. Closing and reopening to try and kick them off again

@everettraven everettraven reopened this Jul 17, 2023
@everettraven everettraven merged commit 1403d71 into operator-framework:master Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adding Owner References for Existing Resources

3 participants