[webhook] Modify ordering of webhook based on name #5301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @sujil02 |
When there are multiple webhooks of the same type, the ordering is not fixed. This PR modifies the ordering of webhooks in a webhookdefinition based on the name, instead of the type. Signed-off-by: varshaprasad96 <[email protected]>
varshaprasad96
force-pushed
the
fix/wh-ordering
branch
from
7bd6f86 to
e738378
Compare
|
New changes are detected. LGTM label has been removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
When there are multiple webhooks of the same type, the
ordering is not fixed. This PR modifies the ordering of webhooks
in a webhookdefinition based on the name, instead of the type.
Signed-off-by: varshaprasad96 [email protected]
Motivation for the change:
Closes: #5215
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs