Add successful condition for Ansible-based operators #5262
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Adds
Successful
condition, as documented. Also no longer removes conditions, just toggles them betweenTrue
andFalse
. for Ansible-based Operators 2.0, probably should revisit this and consider removing either Failed or Successful, as they provide redundant information.Motivation for the change:
Successful condition is documented and has been for many versions. Running condition is difficult to use existing tools to wait for success (have to check
reason
rather than justtype
andstatus
closes #5235
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments
(seechangelog/fragments/00-template.yaml
)website/content/en/docs