Skip to content

Conversation

fabianvf
Copy link
Member

Description of the change:
Adds Successful condition, as documented. Also no longer removes conditions, just toggles them between True and False. for Ansible-based Operators 2.0, probably should revisit this and consider removing either Failed or Successful, as they provide redundant information.

Motivation for the change:
Successful condition is documented and has been for many versions. Running condition is difficult to use existing tools to wait for success (have to check reason rather than just type and status

closes #5235

Checklist

If the pull request includes user-facing changes, extra documentation is required:

Signed-off-by: Fabian von Feilitzsch <[email protected]>
Signed-off-by: Fabian von Feilitzsch <[email protected]>
Signed-off-by: Fabian von Feilitzsch <[email protected]>
@fabianvf fabianvf force-pushed the add-successful-condition branch from 7d65dac to 802ce3e Compare September 30, 2021 18:05
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2021
Copy link
Member

@asmacdo asmacdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@fabianvf fabianvf merged commit eccd240 into operator-framework:master Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ansible Operator sets incorrect condition Running on successful reconciliation

3 participants