[helm] revert changes made to release equality comparison #5097
Conversation
jmrodri
changed the title
jmrodri
requested review from
fabianvf and
joelanford
and removed request for
jmccormick2001
|
Does this need a changelog to indicate that we did a reversion? |
This reverts commit 57ac0fe. Signed-off-by: varshaprasad96 <[email protected]>
…perator-framework#4937)" This reverts commit cae12a2. Signed-off-by: varshaprasad96 <[email protected]>
Signed-off-by: varshaprasad96 <[email protected]>
varshaprasad96
force-pushed
the
revert/helm-4937
branch
from
e5e15cf to
ddbcd1b
Compare
| # - change | ||
| # - deprecation | ||
| # - removal | ||
| # - bugfix |
There was a problem hiding this comment.
not sure if we could have this as bug fix, since there is no issue open caused by the change
There was a problem hiding this comment.
For visibility: this PR reverts a change made intending to improve a manifest equality test that actually broke its behavior. See #5059 (comment) for more details.
I think this closes #5059 too.
/ping @cndoit18
/lgtm
|
merging this pr forcefully, since doc check needs to be fixed |
|
/cherry-pick v1.10.x |
|
@varshaprasad96: new pull request created: #5106 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick v1.9.x |
|
@varshaprasad96: new pull request created: #5107 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick v1.8.x |
|
@varshaprasad96: new pull request created: #5108 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…5106) This is an automated cherry-pick of #5097 Co-authored-by: varshaprasad96 <[email protected]>
…5108) This is an automated cherry-pick of #5097 Co-authored-by: varshaprasad96 <[email protected]>
…5107) This is an automated cherry-pick of #5097 Co-authored-by: varshaprasad96 <[email protected]>
|
Hi, do you provide tips on documentation or a website? |
…ramework#5097) * Revert "fix: issue-5041 (operator-framework#5042)" This reverts commit 57ac0fe. Signed-off-by: varshaprasad96 <[email protected]> * Revert "fix(helm): properly compare existing and candidate releases (operator-framework#4937)" This reverts commit cae12a2. Signed-off-by: varshaprasad96 <[email protected]> * add changelog fragment Signed-off-by: varshaprasad96 <[email protected]>
…ramework#5097) * Revert "fix: issue-5041 (operator-framework#5042)" This reverts commit 57ac0fe. Signed-off-by: varshaprasad96 <[email protected]> * Revert "fix(helm): properly compare existing and candidate releases (operator-framework#4937)" This reverts commit cae12a2. Signed-off-by: varshaprasad96 <[email protected]> * add changelog fragment Signed-off-by: varshaprasad96 <[email protected]> Signed-off-by: Thierry Wasylczenko <[email protected]>
5 participants
This PR reverts:
ref: fix: issue-5041 #5042
ref: fix(helm): properly compare existing and candidate releases #4937
Signed-off-by: varshaprasad96 [email protected]
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs