Skip to content

Conversation

laxmikantbpandhare
Copy link
Member

@laxmikantbpandhare laxmikantbpandhare commented Jul 22, 2021

Description of the change:

Motivation for the change:

Checklist

If the pull request includes user-facing changes, extra documentation is required:

Copy link
Member

@varshaprasad96 varshaprasad96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@laxmikantbpandhare can you run make generate. I would expect testdata/ to be updated.

@laxmikantbpandhare
Copy link
Member Author

@laxmikantbpandhare can you run make generate. I would expect testdata/ to be updated.

@varshaprasad96 - I tried but did not get any testdata files

Signed-off-by: laxmikantbpandhare <[email protected]>
Signed-off-by: laxmikantbpandhare <[email protected]>
Signed-off-by: laxmikantbpandhare <[email protected]>
@laxmikantbpandhare
Copy link
Member Author

@laxmikantbpandhare can you run make generate. I would expect testdata/ to be updated.

Finally, able to generate the testdata.

Copy link
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2021
Copy link
Contributor

@theishshah theishshah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@laxmikantbpandhare laxmikantbpandhare merged commit 09e8145 into operator-framework:v1.9.x Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants