Namespace will now be extracted from request URL when not provided in the body #5064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianvf
force-pushed
the
proxy-detect-ns
branch
4 times, most recently
from
c176e6c to
7778ff2
Compare
… the body Signed-off-by: Fabian von Feilitzsch <[email protected]>
fabianvf
force-pushed
the
proxy-detect-ns
branch
from
7778ff2 to
aa4e3bf
Compare
Signed-off-by: Fabian von Feilitzsch <[email protected]>
estroz
reviewed
Jul 21, 2021
estroz
reviewed
Jul 21, 2021
Signed-off-by: Fabian von Feilitzsch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
If a request is made to a namespaced endpoint, but the body does not contain the namespace, we will now detect that and still properly handle owner reference injection.
Motivation for the change:
Helm secrets were not getting owner references injected because helm creates the resource without setting namespace in the ObjectMeta.
Closes #5038
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs