Skip to content

Fix missing parameter in hook watch #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 12, 2023
Merged

Fix missing parameter in hook watch #235

merged 4 commits into from
Sep 12, 2023

Conversation

@juldrixx
Copy link
Contributor

@juldrixx juldrixx commented Sep 4, 2023 •
edited
Loading

#216 updated the dependentResourceWatcher struct to add the cache and the scheme, but did not initialize them even though they were passed on to creation.
The cache is therefore empty and the code crashs on here.

@juldrixx juldrixx changed the title Fix missing parameter in hook watch Fix missing parameter in hook watch and Upgrade Go 1.21 Sep 4, 2023
stevekuznetsov
stevekuznetsov reviewed Sep 6, 2023
View reviewed changes
@stevekuznetsov
Copy link

stevekuznetsov commented Sep 11, 2023

/ok-to-test
/lgtm
/approve

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm Indicates that a PR is ready to be merged. labels Sep 11, 2023
everettraven
everettraven requested changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@everettraven everettraven left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juldrixx would you mind separating this into 2 PRs? One for the hook watch fix and one for the Go 1.21 bump? We tend to be more cautious when doing a Go bump as it can negatively impact projects that depend on this repository but might not be able to bump Go yet

@juldrixx
Copy link
Contributor Author

juldrixx commented Sep 11, 2023

@juldrixx would you mind separating this into 2 PRs? One for the hook watch fix and one for the Go 1.21 bump? We tend to be more cautious when doing a Go bump as it can negatively impact projects that depend on this repository but might not be able to bump Go yet

Sure

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2023
@openshift-ci
Copy link

openshift-ci bot commented Sep 11, 2023

New changes are detected. LGTM label has been removed.

@juldrixx juldrixx changed the title Fix missing parameter in hook watch and Upgrade Go 1.21 Fix missing parameter in hook watch Sep 11, 2023
@grokspawn grokspawn added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2023
@everettraven everettraven merged commit d00d009 into operator-framework:main Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@everettraven everettraven everettraven approved these changes

@grokspawn grokspawn grokspawn approved these changes

@SimonBaeumer SimonBaeumer Awaiting requested review from SimonBaeumer

@varshaprasad96 varshaprasad96 Awaiting requested review from varshaprasad96

@stevekuznetsov stevekuznetsov Awaiting requested review from stevekuznetsov

Assignees

@stevekuznetsov stevekuznetsov

Labels

area/sdk lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@juldrixx @stevekuznetsov @everettraven @grokspawn