Remove dependence of aries module on VcxStateType

[mirgee]

This PR adds new enums representing current state of IssuerSM, HolderSM, ProverSM and VerifierSM: IssuerState, HolderState, ProverState and VerifierState respectively. Function get_state() returns variants of said enums on the internal aries level, and these are converted to numeric representations on the C-callable level.

Wrapper now exports enums representing these states in place of StateType: IssuerStateType, HolderStateType, VerifierStateType, IssuerStateType, ConnectionStateType.

This is a breaking change, since the variant representations corresponding to the states returned by get_state() function has changed, as well as the numeric representations. For the numeric values, see here, and for the changes to get_state() return values, see corresponding implementations for each of the concerned SMs.

Signed-off-by: Miroslav Kovar [email protected]

[codecov-commenter]

Codecov Report

Merging #314 (8cadbe3) into master (3c2165d) will increase coverage by 0.04%.
The diff coverage is 35.10%.

@@            Coverage Diff             @@
##           master     #314      +/-   ##
==========================================
+ Coverage   49.72%   49.77%   +0.04%     
==========================================
  Files         156      156              
  Lines       19634    19651      +17     
  Branches     6205     6199       -6     
==========================================
+ Hits         9763     9781      +18     
- Misses       5070     5074       +4     
+ Partials     4801     4796       -5     

Flag	Coverage Δ
integration	22.09% <0.80%> (-0.05%)	⬇️
unittests	45.59% <35.10%> (+0.05%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
libvcx/src/api_lib/api_c/credential.rs	27.27% <0.00%> (-0.28%)	⬇️
libvcx/src/api_lib/api_c/credential_def.rs	34.51% <ø> (ø)
libvcx/src/api_lib/api_c/disclosed_proof.rs	34.60% <0.00%> (ø)
libvcx/src/api_lib/api_c/issuer_credential.rs	28.92% <0.00%> (-0.06%)	⬇️
libvcx/src/api_lib/api_c/proof.rs	44.87% <0.00%> (ø)
libvcx/src/api_lib/api_c/wallet.rs	43.66% <ø> (ø)
...aries/handlers/connection/invitee/state_machine.rs	64.50% <0.00%> (ø)
...aries/handlers/connection/inviter/state_machine.rs	64.45% <0.00%> (ø)
libvcx/src/aries/mod.rs	23.07% <ø> (ø)
libvcx/src/lib.rs	0.00% <0.00%> (ø)
... and 19 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c2165d...8cadbe3. Read the comment docs.

[Patrik-Stas]

@mirgee the failing tests seem to indicate that the state mapping is a bit off somewhere

[Patrik-Stas]

Minor changes requested, overally love it! 👍

[Patrik-Stas]

I think it's important for readibility of the code consuming this wrapper to return Struct/Enums from TS function returning state representation (getState, updateState)