[cifmw_ceph_client] Discover and configure Glance with Ceph RGW secrets #3169
Conversation
|
Hi @maximsava12. Thanks for your PR. I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
maximsava12
force-pushed
the
glance-ceph-s3-backend
branch
from
11b8bcc to
f8442b1
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/148eba965ca54ffcb1f99d5cd834ff75 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 48m 15s |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/61cc1357fe544e08a49db0a7898852f2 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 42m 25s |
|
Request for the future: if you keep your pull request "clean" as long as you develop it, you won't need to rebase and clean the pull request when it is ready. So if you update this, please ensure to always have a single commit (unless you want to have more commits, but the commits in this pull request are all updates to the same commit). |
Ack |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/bbd2fe91fbfa4d28843e48791c3b0b10 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 44m 58s |
maximsava12
force-pushed
the
glance-ceph-s3-backend
branch
from
775c2c6 to
18fc8d2
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/b78f7c0247ad4884baa7e18744b0ea35 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 48m 05s |
maximsava12
force-pushed
the
glance-ceph-s3-backend
branch
from
18fc8d2 to
31ba8bc
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/c6e28a41162640f3bf0ae19b627d1b5a ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 44m 15s |
maximsava12
force-pushed
the
glance-ceph-s3-backend
branch
from
31ba8bc to
1677da5
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/2ac991835378471aa3b9ab475f753e13 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 37m 49s |
maximsava12
force-pushed
the
glance-ceph-s3-backend
branch
from
1677da5 to
88fa5f4
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/1d3f5d867f7d40eaa3ad3ec1cf166972 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 48m 56s |
maximsava12
force-pushed
the
glance-ceph-s3-backend
branch
from
88fa5f4 to
3907733
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f1619da0b1ea4e2083066012b26534c8 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 57m 17s |
maximsava12
force-pushed
the
glance-ceph-s3-backend
branch
2 times, most recently
from
5c487c6 to
4b8a24b
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/0b58377b5c1d44f08732f26e86a3b288 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 52m 57s |
maximsava12
force-pushed
the
glance-ceph-s3-backend
branch
from
4b8a24b to
0e4c85c
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/3e7b0388f2294c399c0f70c8320e9605 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 49m 48s |
maximsava12
force-pushed
the
glance-ceph-s3-backend
branch
from
0e4c85c to
de78135
Compare
maximsava12
force-pushed
the
glance-ceph-s3-backend
branch
from
9a340fd to
6cfebee
Compare
| vars: | ||
| ceph_command: radosgw-admin | ||
|
|
||
| - name: Check if Ceph S3 glance user exists |
There was a problem hiding this comment.
Fixed double keys linter error on key ignore_errors
There was a problem hiding this comment.
makes sense as you handle the error with the next task.
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/323e09ca6a7c40d3853ffc8b8e7708ec ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 53m 49s |
fultonj
left a comment
fultonj
left a comment
There was a problem hiding this comment.
Hi @maximsava12,
Do you think you can update this to add to the ceph client role instead?
Thanks,
John
| force: true | ||
|
|
||
| - name: Import glance Ceph RGW discovery playbook | ||
| ansible.builtin.import_tasks: ../../playbooks/glance-rgw-discovery/glance-rgw-discovery.yaml |
There was a problem hiding this comment.
Please use include_tasks on the moved file, glance-rgw-discovery.yaml, instead
| - name: Load vars from ceph admin role | ||
| import_role: | ||
| name: cifmw_cephadm | ||
| tasks_from: main.yml |
There was a problem hiding this comment.
cifmw_cephadm intentionally leaves main.yml blank so this entire task can be removed
| force: true | ||
|
|
||
| - name: Import glance Ceph RGW discovery playbook | ||
| ansible.builtin.import_tasks: ../../playbooks/glance-rgw-discovery/glance-rgw-discovery.yaml |
There was a problem hiding this comment.
Use include_tasks of the moved file instead.
maximsava12
force-pushed
the
glance-ceph-s3-backend
branch
from
6cfebee to
5d6d6c2
Compare
fultonj
left a comment
fultonj
left a comment
There was a problem hiding this comment.
It looks like all of my concerns have been addressed. Thanks Maxim.
|
It would be nice if you could rebase against the latest version of main. Also, let's see the rdo check pass before merging. |
Thank you. |
|
/ok-to-test |
|
/retest |
| --uid="glance" | ||
| --display-name="Glance S3 User" | ||
| when: cifmw_ceph_s3_glance_user_check != 0 | ||
| register: cifmw_ceph_s3_glance_user |
There was a problem hiding this comment.
(non-blocking) question: Do we want this var?
There was a problem hiding this comment.
cifmw_ceph_s3_glance_user can be removed
There was a problem hiding this comment.
Removed var cifmw_ceph_s3_glance_user
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/49c52abaa9624e7c9c2e66bc39926f00 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 47m 01s |
maximsava12
force-pushed
the
glance-ceph-s3-backend
branch
from
5d6d6c2 to
c861df8
Compare
|
Fixed set_fact FQDN module error in |
maximsava12
force-pushed
the
glance-ceph-s3-backend
branch
from
c861df8 to
00517cf
Compare
This patch enhances the cifmw_ceph_client role to: - Automatically discover Ceph RGW (RADOS Gateway) endpoint and credentials - Create Glance secrets using the discovered RGW settings - Configure glance with Ceph RGW secrets This integration configures Glance with Ceph RGW access credentials, enabling it to use RGW as an Glance backend when object storage is enabled Changes: - Add RGW discovery playbook - Add logic to create Glance secrets with RGW config Signed-off-by: Maxim Sava <[email protected]>
maximsava12
force-pushed
the
glance-ceph-s3-backend
branch
from
00517cf to
9b5f23b
Compare
maximsava12
changed the title
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/43034d6beb1544e2ad271f00ce939ca6 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 39m 09s |
7 participants
This patch enhances the cifmw_ceph_client role to:
This integration allows Glance to leverage Ceph RGW for secret storage when object store backends are enabled in the environment.
Changes: