Skip to content

Conversation

@masco
Copy link
Contributor

@masco masco commented Nov 12, 2025

with this PR we can enable and disable telemetry based on needs with storage.

@openshift-ci
Copy link

openshift-ci bot commented Nov 12, 2025

Hi @masco. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@fultonj
Copy link
Contributor

fultonj commented Nov 17, 2025

So with this patch the OpenStackControlPlane is changed this way.

--- /tmp/OpenStackControlPlane_orig.yaml        2025-11-17 10:59:32.492375708 -0500
+++ /tmp/OpenStackControlPlane.yaml     2025-11-17 10:59:22.801990421 -0500
@@ -528,7 +528,8 @@
         enabled: false
         port: 10514
       metricStorage:
-        enabled: false
+        dataplaneNetwork: ctlplane
+        enabled: true
         monitoringStack:
           alertingEnabled: true
           scrapeInterval: 30s
@@ -538,3 +539,5 @@
               pvcStorageRequest: 10Gi
             retention: 24h
             strategy: persistent
+        networkAttachments:
+        - ctlplane
[fultonj@stybba scalelab{main}]$ 

Copy link
Contributor

@fultonj fultonj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Nov 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fultonj, masco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants