-
Notifications
You must be signed in to change notification settings - Fork 0
Candidate Release #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR prepares the NopPlugins solution for release by registering new plugins, improving the devcontainer environment for local development (data persistence, streamlined settings), and adding Dockerfiles/scripts for installing Claude CLI in development containers.
- Registered three new plugins in the NopCommerce solution.
- Enhanced devcontainer/docker-compose configuration (persistent SQL data, simplified JSON).
- Added multiple Dockerfiles and helper scripts to install and verify Claude CLI in containers.
Reviewed Changes
Copilot reviewed 26 out of 26 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| nul | Introduced placeholder “nul” file with error output |
| nopPlugins/src/NopCommerce.sln | Added three new plugin projects to the solution |
| nopPlugins/.devcontainer/docker-compose.yml | Added named volume for MSSQL data persistence |
| containers/devcontainers/Nop.Web/Dockerfile | Expanded installs (tools, Claude CLI, Oh My Zsh) |
Comments suppressed due to low confidence (3)
nopPlugins/.devcontainer/docker-compose.yml:1
- [nitpick] The hard-coded local filepath comment is environment-specific and may confuse other developers; remove or replace it with a generic reference.
+# filepath: /home/brett/projects/nopSetup/nopPlugins/.devcontainer/docker-compose.yml
nul:1
- This file appears to be an accidental placeholder or test artifact and doesn’t belong in the repository. Consider removing
nulor clarifying its purpose.
+./setup.cmd: 2: @goto: not found
containers/devcontainers/Nop.Web/Dockerfile:48
- This COPY will fail if
.zshrcis not present in the build context. Ensure the file is included or add a conditional check to avoid build errors.
+COPY .zshrc /root/.zshrc
| @@ -0,0 +1,26 @@ | |||
| # Test Dockerfile for Claude CLI installation | |||
Copilot
AI
Jun 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] This test Dockerfile is nearly identical to test-claude-dockerfile; consider consolidating or parameterizing to reduce duplication.
| read -p "Do you want to continue? This will clone into the existing directory. (y/N): " -r | ||
| if [[ ! $REPLY =~ ^[Yy]$ ]]; then | ||
| echo -e "${BLUE}Clone operation cancelled${NC}" | ||
| exit 0 |
Copilot
AI
Jun 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Interactive prompts can hang automation pipelines. Consider adding a --force flag or a non-interactive mode to allow scripted use.
| read -p "Do you want to continue? This will clone into the existing directory. (y/N): " -r | |
| if [[ ! $REPLY =~ ^[Yy]$ ]]; then | |
| echo -e "${BLUE}Clone operation cancelled${NC}" | |
| exit 0 | |
| if [ "$FORCE" = false ]; then | |
| read -p "Do you want to continue? This will clone into the existing directory. (y/N): " -r | |
| if [[ ! $REPLY =~ ^[Yy]$ ]]; then | |
| echo -e "${BLUE}Clone operation cancelled${NC}" | |
| exit 0 | |
| fi | |
| else | |
| echo -e "${BLUE}Force mode enabled. Skipping confirmation prompt.${NC}" |
Almost ready to give to NopDevs. Test this one well.