- 
                Notifications
    
You must be signed in to change notification settings  - Fork 2k
 
Remove gathering of loadbalancers from openstack-gather step #70212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove gathering of loadbalancers from openstack-gather step #70212
Conversation
This is currently causing failures. We do not have enough context to figure out what is going on, so remove the steps for now so we can debug later. Signed-off-by: Stephen Finucane <[email protected]>
| 
           /pj-rehearse pull-ci-openshift-csi-operator-main-e2e-openstack-cinder-csi  | 
    
| 
           @stephenfin: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.  | 
    
| 
           [REHEARSALNOTIFIER] 
 A total of 1129 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment:  Once you are satisfied with the results of the rehearsals, comment:   | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
| # load balancers | ||
| 
               | 
          ||
| openstack loadbalancer list -f json \ | ||
| | jq --arg CLUSTER_NAME "$CLUSTER_NAME" 'map(select(.name | test($CLUSTER_NAME)))' \ | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it have been map(select(.Name | test($CLUSTER_NAME))) with uppercase Name? For when we restore the additional log gathering.
Let's drop the change for now since it's causing the CI to fail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I think name is correct. This works locally for me.
❯ openstack loadbalancer list -f json | jq --arg CLUSTER_NAME "phbbp-hchsv" 'map(select(.name | test($CLUSTER_NAME)))'
[
  {
    "id": "1dc263eb-0505-4a2b-af2c-c5a1d4dae968",
    "name": "kube_service_autoscaling-phbbp-hchsv_openshift-ingress_router-default",
    "project_id": "0693e2bb538c42b79a49fe6d2e61b0fc",
    "vip_address": "10.0.0.167",
    "provisioning_status": "ERROR",
    "operating_status": "OFFLINE",
    "provider": "amphora"
  }
]
| 
           [APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mandre, stephenfin The full list of commands accepted by this bot can be found here. The pull request process is described here 
Needs approval from an approver in each of these files:
 
      
 Approvers can indicate their approval by writing   | 
    
| 
           @stephenfin: The following test failed, say  
 Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.  | 
    
| 
           The rehearsal failed but the relevant step passed, so... /pj-rehearse ack  | 
    
| 
           @stephenfin: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.  | 
    
0776a4f
      into
      
  
    openshift:master
  
    This is currently causing failures. We do not have enough context to figure out what is going on, so remove the steps for now so we can debug later. Signed-off-by: Stephen Finucane <[email protected]>
This is currently causing failures. We do not have enough context to figure out what is going on, so remove the steps for now so we can debug later. Signed-off-by: Stephen Finucane <[email protected]>
This is currently causing failures. We do not have enough context to figure out what is going on, so remove the steps for now so we can debug later. Signed-off-by: Stephen Finucane <[email protected]>
We are currently seeing failures in this step. Based on what we are able to collect, it seems the gathering of load balancers is the issue. We do not have enough context to figure out what is going on, so remove the steps for now so we can debug later.