-
Notifications
You must be signed in to change notification settings - Fork 4.8k
MG-110: Sync the test template for MG #30374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/assign @ming1013 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: KeenonLee The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @ming1013 ,Please help to take a look, THX |
|
@KeenonLee: This pull request references MG-110 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Shall we still need to do this? Since there is a w/a to replace bindata.go via overlay mechanism. So OTP users don’t have to update template files and bindatago in origin but to maintain them separately. |
|
@KeenonLee: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@KeenonLee According what we discussed, I think we can close this PR. WDYT? |
|
@ming1013 I just need to modify it in the testdata of OTP, right? |
In OTP or after the test code is migrated then in your component repo. |
test panicked: Asset test/extended/testdata/oap/mustgather not found