Skip to content

Conversation

@jakurban
Copy link

The pickle module implements binary protocols for serializing and de-serializing a Python object structure and with the default serializer it wasn't possible to serialize APIObjects, therefore it is necessary to create a custom one.

@openshift-ci openshift-ci bot requested review from bradmwilliams and jupierce June 20, 2023 12:40
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 20, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jun 20, 2023

Hi @JaurbanRH. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bradmwilliams
Copy link
Contributor

/ok-to-test
@JaurbanRH I've applied the label to test, but it's going to fail because you'll need to run the ./ansible/rebuild_module.sh locally and include the updated files.

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 26, 2023
@jakurban
Copy link
Author

/retest

@jakurban jakurban requested a review from bradmwilliams June 27, 2023 09:29
@openshift-ci
Copy link

openshift-ci bot commented Jun 27, 2023

@JaurbanRH: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 27, 2023
@bradmwilliams
Copy link
Contributor

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2023
@bradmwilliams
Copy link
Contributor

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 27, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jun 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bradmwilliams, hoxhaeris, JaurbanRH

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bradmwilliams
Copy link
Contributor

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 27, 2023
@openshift-merge-robot openshift-merge-robot merged commit ba26a10 into openshift:main Jun 27, 2023
@bradmwilliams
Copy link
Contributor

@JaurbanRH Your changes have been packaged and released in version 1.0.19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants