Marking references to api_url as deprecated
#141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
approved
bradmwilliams
force-pushed
the
default-api-url-fix
branch
from
6c6c87a to
7d24398
Compare
hoxhaeris
approved these changes
Jun 27, 2023
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
bradmwilliams
force-pushed
the
default-api-url-fix
branch
from
7d24398 to
c5e6634
Compare
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
hoxhaeris
approved these changes
Jun 27, 2023
|
@bradmwilliams: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bradmwilliams, hoxhaeris The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mdujava
added a commit
to mdujava/3scale-tests
that referenced
this pull request
Aug 7, 2024
mdujava
added a commit
to mdujava/3scale-tests
that referenced
this pull request
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #140
@jramcast Thanks for your PR. I took a look at the code and thought it might be better to make a few more changes and flag the impacted APIs as deprecated (just in case there is anyone who actually uses them). I thought about introducing the deprecation module, but that'll certainly break folks if/when then choose to upgrade. So, although this is a little rough around the edges, I think it'll accomplish what you were trying to do, provide the backward compatibility we'd like to maintain, and I'll create an issue to remove the deprecated APIs.