OCPBUGS-59311: oc adm must-gather: Add support for context #2105
Conversation
openshift-ci-robot
added
jira/valid-reference
|
@tchap: This pull request references Jira Issue OCPBUGS-59311, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
requested review from
ardaguclu,
atiratree and
zhouying7780
|
/retest |
The former queue implementation is deprecated.
When the temporary must-gather role binding fails to be created, no namespace cleanup function is returned and the namespace is left behind. This is now fixed by returning the namespace cleanup function on error.
Currently defer queue.Done(pod) is called in a worker thread loop, which means that the pod is marked as done when the whole worker thread exits and not in that pod processing loop iteration. This is now fixed and the pod is marked as processed as soon as it is actually processed.
tchap
force-pushed
the
must-gather-use-context
branch
from
eb52134 to
47bf325
Compare
This is in preparation of proper signal handling.
tchap
force-pushed
the
must-gather-use-context
branch
from
47bf325 to
6a2ebc9
Compare
|
@ardaguclu Split into multiple commits as requested. |
|
That is nice! Thank you |
openshift-ci
bot
added
lgtm
|
/retest |
|
The CI results are not in a good shape (maybe unrelated?). But we need to be sure that. |
openshift-ci
bot
removed
lgtm
|
Yeah, I don't think it's us, because before I did the commit split, everything was green AFAIK. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ardaguclu, tchap The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest |
1 similar comment
|
/retest |
|
/retest |
|
@tchap: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/verified by @tchap |
openshift-ci-robot
added
the
verified
|
@tchap: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-merge-bot
bot
merged commit abe2393
into
openshift:main
|
@tchap: Jira Issue OCPBUGS-59311: Some pull requests linked via external trackers have merged: The following pull request, linked via external tracker, has not merged:
All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-59311 has not been moved to the MODIFIED state. This PR is marked as verified. If the remaining PRs listed above are marked as verified before merging, the issue will automatically be moved to VERIFIED after all of the changes from the PRs are available in an accepted nightly payload. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
3 participants
This is in preparation of proper signal handling.
Split from #2062