Skip to content

Updates to mongo and makefile to reduce flakes. #1978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: oadp-dev
Choose a base branch
from
Open

Updates to mongo and makefile to reduce flakes. #1978

wants to merge 9 commits into from

Conversation

weshayutin
Copy link
Contributor

@weshayutin weshayutin commented Oct 6, 2025 •
edited
Loading

Why the changes were made

  • improve the basic todolist-mongo app iteself
  • improve the todolist-mongo openshift manifests
  • add retry to oadp cli backup/restore log call
  • ginkgo.Entry("Mongo application KOPIA in either b/r suite or cli suite is NOT worth the flakiness imho.. Kill it.
  • Update the Makefile to allow GINKGO_ARGS="--focus='FOO' to work again.

All in the hopes of making tihs app more reliable
konveyor/mig-demo-apps#109

How to test the changes made

  • run the e2e tests in full or a single test

@weshayutin weshayutin added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 6, 2025
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2025
@weshayutin
Copy link
Contributor Author

deployconfigs have been switched to deployments for mongo, need to adjust

@openshift-ci openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2025
@weshayutin
Copy link
Contributor Author

/test images

@weshayutin weshayutin changed the title DNM-TESTING updated mongo-todo Updates to mongo and makefile to reduce flakes. Oct 10, 2025
@weshayutin weshayutin added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Oct 10, 2025
kaovilai
kaovilai reviewed Oct 10, 2025
View reviewed changes
tests/e2e/backup_restore_suite_test.go
Comment on lines +40 to +41
// perhaps we phase out deploymentConfigs?
//gomega.Eventually(lib.IsDCReady(ocClient, namespace, "todolist"), time.Minute*10, time.Second*10).Should(gomega.BeTrue())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As of Red Hat OpenShift Container Platform 4.14, DeploymentConfig API is deprecated. DeploymentConfig objects are still supported, but are not recommended for new installations. Only security-related and critical issues will be fixed. Instead, use of Deployment objects is recommended.

In addition, Red Hat OpenShift Container Platform 4.14 and later installation allow for disabling the DeploymentConfig capability, among other optional Cluster capabilities.

Could do to simplify. but its still supported.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aye.. probably not something we need in our dev ci though :) IMHO.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai, weshayutin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@weshayutin
Copy link
Contributor Author

/test images

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 10, 2025

@weshayutin: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kaovilai
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaovilai kaovilai kaovilai approved these changes

@eemcmullan eemcmullan Awaiting requested review from eemcmullan

@savitharaghunathan savitharaghunathan Awaiting requested review from savitharaghunathan

At least 2 approving reviews are required to merge this pull request.

Assignees

@kaovilai kaovilai

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weshayutin @kaovilai